migrate protos #439
Merged
migrate protos #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 34 34
Lines 2735 2735
=======================================
Hits 1892 1892
Misses 734 734
Partials 109 109
☔ View full report in Codecov by Sentry. |
|
@mikeee can you fix the PR? we want to migrate the protos from dapr/dapr for the upcoming 1.12 release |
|
Sure, sorry it's been on my to-do. I'll rework it today |
mikeee
force-pushed
the
mikeee-migrate_protos
branch
from
c04adbe to
61e018b
Compare
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
mikeee
force-pushed
the
mikeee-migrate_protos
branch
from
61e018b to
26c0a3f
Compare
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
|
@yaron2 ready for your eyes |
yaron2
approved these changes
Sep 26, 2023
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in #381 this will reference protos in the dapr/dapr repo rather than being copied.
Merging this will close #381
Signed-off-by: mikeee [email protected]